Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cadence Type onboarding blocklist functionality #139

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Add Cadence Type onboarding blocklist functionality #139

merged 2 commits into from
Dec 19, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Dec 19, 2024 •
edited
Loading

Description

  • Adds the ability to manually block Cadence Types from onboarding to the bridge

For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.37%. Comparing base (02aab3f) to head (9786520).
Report is 183 commits behind head on main.

Files with missing lines Patch % Lines
cadence/contracts/bridge/FlowEVMBridgeConfig.cdc 54.54% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   86.19%   86.37%   +0.17%     
==========================================
  Files          18       18              
  Lines         884      976      +92     
==========================================
+ Hits          762      843      +81     
- Misses        122      133      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling force-pushed the gio/add-cadence-onboarding-blocklist branch from 148c8be to e28c934 Compare December 19, 2024 21:27
@sisyphusSmiling sisyphusSmiling force-pushed the gio/add-cadence-onboarding-blocklist branch from e28c934 to 9786520 Compare December 19, 2024 21:30
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review December 19, 2024 21:31
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner December 19, 2024 21:31
@sisyphusSmiling sisyphusSmiling self-assigned this Dec 19, 2024
@sisyphusSmiling sisyphusSmiling merged commit 8765428 into main Dec 19, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the gio/add-cadence-onboarding-blocklist branch December 19, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvdtf nvdtf nvdtf approved these changes

Assignees

@sisyphusSmiling sisyphusSmiling

Labels
Feature
Projects
FlowEVM Bridge
Status: Done
🌊 Flow 4D
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sisyphusSmiling @codecov-commenter @nvdtf